[Freeipa-devel] [PATCH] admiyo 0012 ldap_initialize

[Rob Crittenden]

Adam Young wrote:
> On 08/19/2010 08:31 PM, Adam Young wrote:
>> On 08/19/2010 05:45 PM, Rob Crittenden wrote:
>>> Adam Young wrote:
>>>> Gets rid of the last of our compiler warnings by removing a deprecated
>>>> function call :ldap_init should be replaced with ldap_initialize.
>>>>
>>>> https://fedorahosted.org/freeipa/attachment/ticket/151/admiyo-freeipa-0012-ldap_initialize.patch
>>>>
>>>>
>>>>
>>>
>>> I think the scheme should be ldaps and not ldap in the port 636 case.
>>> I'm not sure you need/want to set errno either.
>>>
>>> rob
>>
>>
>> I think you are right on "ldaps". I'm guesiing we don't havea test
>> case for that/ As for errno, malloc will set it to ENOMEM, so we
>> should probably leave it.
>>
>> I'll post an updated patch.
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
> ldaps.
> Not setting errno

ACK