[Freeipa-devel] [PATCH] 619 more aci target docs

[Rob Crittenden]

Rob Crittenden wrote:
> David O'Brien wrote:
>> Rob Crittenden wrote:
>>> I added some more documentation and examples to the aci plugin on
>>> targets.
>>>
>>> ticket 310
>>>
>>> rob
>>>
>> NACK
>>
>> Running behind with reviews, sorry. Just a few minor fixes:
>>
>> s/targetted/targeted/
>> s/"This is primarily meant to be able to allow users to add/remove
>> members of a specific group only."/"This is primarily designed to enable
>> users to add or remove members of a specific group."
>>
>> (I _think_ I understood that ok, and didn't change the meaning. Further,
>> if this target is only designed for this purpose, you don't need
>> "primarily". If it does something else, what is it?)
>>
>> I couldn't grok 100% the "subtree" target description.
>>
>> s/"... the ACI is allowed to do, they are one or more of:"/"... the ACI
>> is allowed to do, and are one or more of:"
>>
>> For consistency's sake, s/lets/allows/ etc. Also see below:
>> allows members of the "addusers" taskgroup
>> lets members of the editors... group?
>> lets members of the admin group
>>
>> You might need to review the examples a bit.
>>
>> cheers
>
> Updated patch.
>
> rob
>

Ok, the right updated patch this time.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-619-2-aci.patch
Type: text/x-patch
Size: 3955 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101202/5f2afeef/attachment.bin>