[Freeipa-devel] [PATCH] Make pkey always iterable when deleting

[Jan Zelený]

Jakub Hrozek <jhrozek at redhat.com> wrote:
> On 12/20/2010 03:07 PM, Jan Zelený wrote:
> > Jakub Hrozek <jhrozek at redhat.com> wrote:
> >> When deleting multiple objects, the code tries to enforce that the
> >> primary key is always iterable by doing:
> >> 
> >> keys = keys[:-1] + (keys[-1], )
> >> 
> >> But this doesn't work, the line only concatenates two tuples effectively
> >> returning the original one. See the attached patch for a fix.
> > 
> > nack: you have the condition in chunk #2 wrong - pkeyiter will be never
> > None
> > 
> > Jan
> 
> Thanks, attached is a new patch.

ack

Jan