[Freeipa-devel] [PATCH] Make the DNS forwarders interactive input less confusing

[Martin Nagy]

On Tue, 2010-02-16 at 13:46 -0500, Rob Crittenden wrote:
> Martin Nagy wrote:
> > Here's the simple patch for #558984.
> > 
> > Specifically, with this patch, ipa-server-install/ipa-dns-install will
> > ask you this:
> > 
> > Do you wish to configure DNS forwarders?
> > 
> > If you say yes, you will also see:
> > 
> > Please enter the IP addresses of DNS forwarders that you want to use.
> > After you are done, enter a blank line to stop.
> > 
> > And the rest is the same, except it doesn't say "(empty to stop)" at the
> > end of the prompt as it used to.
> > 
> > David, Jenny, do you think this is good enough? I can change it easily
> > if there are any objections/ideas.
> > 
> > Patch attached.
> > Martin
> 
> Ack, pushed to master.
> 
> I have another suggestion. When verify_ip_address() fails it would be 
> nice if it would also say "not adding to list" or something. It isn't 
> obvious that the forwarder isn't added when reverse dns fails.
> 
> rob

Yeah, that's a very good idea, I'll make another patch later for this
(post-alpha 2 should be fine). Thanks.

Martin