[Freeipa-devel] [PATCH] jderose 037 Fix broken unit tests

Jason Gerard DeRose jderose at redhat.com
Wed Jan 27 14:25:40 UTC 2010


This patch gets (almost) all the XML-RPC tests working again under
Fedora12.  Some may not pass under Fedora11 due to 389 schema changes,
but Fedora12 should be our primary test target at this point, IHMO.
Does anyone disagree?

3 cert tests still fail, but I'm not familiar enough with the cert
plugins to confidently decide whether the tests need to be updated or
whether something is broken.  Rob or John, could you take a look at
these when you get a chance?

We really need to get strict about patches with regard to tests.  If a
patch breaks a test, the test needs to be updated in that same patch (or
if the test is correct, the code needs to be updated).  If a patch
introduces new functionality, it must be accompanied by tests.

Rob and Pavel, I'm looking at you.  If tests no passy, no acky-acky.  ;)

I know I've been at fault too, but I've already scolded myself off-list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jderose-037-fix-broken-tests.patch
Type: text/x-patch
Size: 10607 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20100127/58841ab6/attachment.bin>


More information about the Freeipa-devel mailing list