[Freeipa-devel] [PATCH] jderose 053 XML-RPC signature change

Rob Crittenden rcritten at redhat.com
Tue Mar 30 19:11:06 UTC 2010


John Dennis wrote:
> On 03/26/2010 09:22 AM, John Dennis wrote:
>> On 03/26/2010 07:24 AM, Jason Gerard DeRose wrote:
>>> This quick patch changes the XML-RPC signature to match the
>>> complementary change being made in certmonger.
>>>
>>> The signature is now:
>>>
>>> [args, options]
>>>
>>> This doesn't yet include the [args, options, extra] change... that is
>>> coming in my rpcserver patch once it's done. But this provides what
>>> needed for current IPA<=> certmonger compatibility.
>>
>> NAK
>>
>> Is there a reason for the type inconsistency? Why is it a list in one
>> case and a tuple in the other? I realize they'll both operate the same
>> way but the inconsistency is confusing especially if there is no reason
>> to use different type objects (e.g. no need for a mutable sequence).
>>
> 
> Jason has promised to fix the consistency issue in a subsequent patch so 
> I'll ACK this now so it can get in.
> 

Ok, pushed to master

rob




More information about the Freeipa-devel mailing list