[Freeipa-devel] [PATCH] 394 Catch empty updates

Martin Nagy mnagy at redhat.com
Sun Mar 7 11:06:42 UTC 2010


On 03/04/2010 10:25 PM, Rob Crittenden wrote:
> Currently if you pass in an empty update on the cli it won't throw an
> error and can be a bit confusing.
>
> rob

I think the change in pwpolicy.py won't preserve the original behaviour:
+        if 'group' in options:
+            group_cn = options['group']
+            del options['group']
+        else:
              group_cn = _global
+
+        if not 'group' in options:
              ...
          else:
              ...

Notice that at the second if, 'group' will never be in options no matter 
what.

Martin




More information about the Freeipa-devel mailing list