[Freeipa-devel] [PATCH 5/5] localize doc strings

Jason Gerard DeRose jderose at redhat.com
Tue Mar 9 04:14:11 UTC 2010


On Fri, 2010-03-05 at 16:21 -0500, John Dennis wrote:
> A number of doc strings were not localized, wrap them in _().
> Some messages were not localized, wrap them in _()
> 
> Fix a couple of failing tests:
> The method name in RPC should not be unicode.
> The doc attribute must use the .msg attribute for comparison.
> 
> Also clean up imports of _() The import should come from
> ipalib or ipalib.text, not ugettext from request.
> 
> Pavel: You'll need to make a fix to plugins/migration.py, look for the 
> FIXME comment. What you're doing with the doc string won't work with our 
> localization framework. I implemented a workaround for the time being.

ack.  pushed to master.

John, for me your 'the_method' change broke the test, which was
previously working.  I pushed this anyway as this patch touches a lot of
files and I don't want us to get into merge hell.  We can fix this small
issue in a separate patch.




More information about the Freeipa-devel mailing list