[Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0075-Ticket-Expiration.patch

[Adam Young]

On 11/06/2010 12:45 AM, Endi Sukma Dewata wrote:
> On 11/5/2010 6:52 PM, Adam Young wrote:
>> Here it is.
>
> ACK-ish.. :)
>
> The error handling on ticket expiration works, but there are some 
> minor issues:
>
> 1. The IPA variable is declared twice.
>
> +var IPA;
>  var IPA = ( function () {
>
> 2. IPA_DEFAULT_JSON_URL should be deleted.
>
>  var IPA_DEFAULT_JSON_URL = '/ipa/json';
> +    var default_json_url = '/ipa/json';
>
> 3. Is it necessary to call hasOwnProperty() in this loop?
>    Variable "a" is obtained from attribute_members, so
>    I think the hasOwnProperty() will always return true.
>
>      for (var a in attribute_members) {
> +        if (attribute_members.hasOwnProperty(a)){
>
> If you could fix this before pushing that would be great. Thanks!
>
Fixed and pushed to master.

The hasOwnProperty check was for JSLint, but I think that it is actually 
wrong in this situation, and I removed it.