[Freeipa-devel] [PATCH] 004 Log script options to logfile

Rob Crittenden rcritten at redhat.com
Mon Nov 8 20:00:30 UTC 2010


Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Uses a new subclass IPAOptionParser in scripts instead of OptionParser
> from the standard python library. IPAOptionParser uses its own IPAOption
> class to store options, which adds a new 'sensitive' attribute.
>
> https://fedorahosted.org/freeipa/ticket/393

This is a good start and does what I requested, I just wasn't clear 
enough in the request.

I think we should log the interactive data as well.

This patch is fine as-is so I'll give you a choice:

1. You can update this patch and log those things that will be queried 
if not provided on the CLI.

2. I can ACK and push this and we can open a new ticket for additional 
enhancements.

rob




More information about the Freeipa-devel mailing list