[Freeipa-devel] [PATCH] Fix a couple of problems in C code

[Jakub Hrozek]

[PATCH 1/6] Common include file for SLAPI plugin logging
Consolidate the common logging macros into common/util.h and use them
in SLAPI plugins instead of calling slapi_log_error() directly.

https://fedorahosted.org/freeipa/ticket/408

[PATCH 2/6] Stricter compilation flags
Use a little stricter compilation flags, in particular -Wall and treat
implicit function declarations as errors.

[PATCH 3/6] Use internal implementation of internal Kerberos functions
Don't use KRB5_PRIVATE.

The patch implements and uses the following krb5 functions that are
otherwise private in recent MIT Kerberos releases:
 * krb5_principal2salt_norealm
 * krb5_free_ktypes

[PATCH 4/6] Don't use deprecated ldap_bind_s
ldap_bind_s is marked as deprecated in new libldap releases.

[PATCH 5/6] Silence compilation warnings in SLAPI plugins
The most important part of the patch is exporting hexbuf() in ipapwd.h
Also uses strcasecmp() instead of PL_strcasecmp() since we were not
including nspr headers and linking against it - I hope this is OK, we
can revert if we need to be portable to platforms with no strcasecmp().
The rest are cosmetic fixes.

[PATCH 6/6] ipa-client code cleanup
Fixes errors about implicit function declaration and moves duplicated
gettext code into a common module. Also silences some warnings.

Patches 3 - 6 fix https://fedorahosted.org/freeipa/ticket/454
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-0005-Common-include-file-for-SLAPI-plugin-logging.patch
Type: text/x-patch
Size: 81063 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101108/701c3e4e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-0006-Stricter-compilation-flags.patch
Type: text/x-patch
Size: 6305 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101108/701c3e4e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-0007-Use-internal-implementation-of-internal-Kerberos-fun.patch
Type: text/x-patch
Size: 5561 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101108/701c3e4e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-0008-Don-t-use-deprecated-ldap_bind_s.patch
Type: text/x-patch
Size: 1356 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101108/701c3e4e/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-0009-Silence-compilation-warnings-in-SLAPI-plugins.patch
Type: text/x-patch
Size: 18020 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101108/701c3e4e/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-0010-ipa-client-code-cleanup.patch
Type: text/x-patch
Size: 9125 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101108/701c3e4e/attachment-0005.bin>