[Freeipa-devel] [PATCH] 017 Init smods to prevent crash if encode_keys fails

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

If encode_keys() failed, we would free the variable smods which is
unitilialized at the time.

btw I've seen encode_keys() fail on me during ber-encoding of the octet
part of the key..which is how I found this bug. I'm not able to
reproduce it ATM and I've been upgrading to 389-ds 1.2.7 just before
that, so maybe it was related to the upgrade..should I just file a bug
or check if I can reproduce it again?

	Jakub

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzvrx4ACgkQHsardTLnvCUT2gCgtdl5/Q6tt3doF4lB48KyWwVa
oqcAn20dPr2vL3Te8YMV65m7DjRm/Su2
=Xb4I
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jhrozek-017-Init-smods-to-prevent-crash-if-encode_keys-fails.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101126/782a51b5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jhrozek-017-Init-smods-to-prevent-crash-if-encode_keys-fails.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101126/782a51b5/attachment.sig>