[Freeipa-devel] [PATCH] 544 add import to automount

[Adam Young]

On 10/12/2010 02:20 PM, Rob Crittenden wrote:
> Rob Crittenden wrote:
>> Add ability to import automount files from the command-line.
>>
>> Support is fairly basic right now and will only work on the CLI. All the
>> work is done on the client side.
>>
>> To continue past errors use the --continue option.
>>
>> Fixed a bug where direct mounts weren't always added properly.
>>
>> Added real user documentation to the plugin.
>>
>> rob
>
> Updated patch. The local get_args() isn't needed any more.
>
> rob
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
ACK


This really should have a unit test.
It doesn't fail too cleanly:

[ayoung at ipa freeipa]$ echo BLAH > /tmp/automount.garbage
[ayoung at ipa freeipa]$ ipa  automountlocation-import /tmp/automount.garbage
Master file:
[ayoung at ipa freeipa]$ ipa  automountlocation-import default 
/tmp/automount.garbage
ipa: ERROR: non-public: IndexError: list index out of range
Traceback (most recent call last):
   File "/usr/lib/python2.6/site-packages/ipalib/backend.py", line 125, 
in execute
     result = self.Command[_name](*args, **options)
   File "/usr/lib/python2.6/site-packages/ipalib/frontend.py", line 401, 
in __call__
     ret = self.run(*args, **options)
   File "/usr/lib/python2.6/site-packages/ipalib/frontend.py", line 675, 
in run
     return self.forward(*args, **options)
   File "/usr/lib/python2.6/site-packages/ipalib/plugins/automount.py", 
line 358, in forward
     if am[1].startswith('/'):
IndexError: list index out of range
ipa: ERROR: an internal error has occurred

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101012/4a28929f/attachment.htm>