[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] #403 Handle multiline options in sysconfig.ntpd



On Fri, 22 Oct 2010 16:43:47 -0400
Rob Crittenden <rcritten redhat com> wrote:

> Simo Sorce wrote:
> > On Thu, 21 Oct 2010 17:07:01 -0400
> > Simo Sorce<ssorce redhat com>  wrote:
> >
> >> On Wed, 20 Oct 2010 22:25:26 -0400
> >> Rob Crittenden<rcritten redhat com>  wrote:
> >>
> >>> Simo Sorce wrote:
> >>>>
> >>>> In some Fedora versions /etc/sysconfig/ntpd has OPTIONS scattered
> >>>> on multiple line through shell expansion.
> >>>> Handle simple cases like that.
> >>>>
> >>>> Simo.
> >>>
> >>> I think this will work, it's just one heck of a parser. Is
> >>> something like the attached a simpler approach?
> >>>
> >>> My version always adds the new options to the first OPTIONS block,
> >>> I'm not sure if it matters.
> >>
> >> Your solution looks a lot smaller indeed.
> >> And less is more here!
> >> I will produce a new patch inspired by this code and post it.
> >> Self-nack on the current patch.
> >
> > Ok, new version that adopts your method attached.
> >
> > Simo.
> 
> ack

pushed to master

Simo.


-- 
Simo Sorce * Red Hat, Inc * New York


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]