[Freeipa-devel] [PATCHES] UUID Plugin: Code fixes and cleanups

Simo Sorce ssorce at redhat.com
Mon Oct 25 22:28:42 UTC 2010


These are a few minor fixes and cleanups I split in multiple patches
for easier review.

1. makes sure we reset the generate flag at every loop, so that we do
not risk a false positive if multiple UUIDs are generated on an entry.

2. makes unlocks safer by tracking when we need to unlock and doing so
in the cleanup code. This is necessary as later code will be introduced
that may error out in the middle of the main loop.

3. tidy up some code and remove one nesting level (hopefully making
stuff slightly more readable). This is possible thanks to (2).

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ipa-uuid-Reset-generate-flag-at-every-cycle.patch
Type: text/x-patch
Size: 1314 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101025/73594e92/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ipa-uuid-safer-unlock-handling.patch
Type: text/x-patch
Size: 1486 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101025/73594e92/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ipa-uuid-Code-cleanups.patch
Type: text/x-patch
Size: 17643 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101025/73594e92/attachment-0002.bin>


More information about the Freeipa-devel mailing list