[Freeipa-devel] [PATCH] admiyo-freeipa-0024-user-whoami.patch

[Rob Crittenden]

Adam Young wrote:
> admiyo-freeipa-0024-user-whoami.patch broke the user-find, due to a
> missing return statement. It has been reverted. Here is the corrected one.

NACK.

I think you want to use false for options.get:
   if options.get('whoami', False):

Otherwise it will always return the whoami version.

I'm not sure which is most efficient when building a string but it is 
easier to read the filter this way IMHO:

     return "(&(objectclass=posixaccount)(krbprincipalname=%s))"%\
        util.get_current_principal()

rob