[Freeipa-devel] [PATCH]admiyo-freeipa-0041-self-service.patch

[Adam Young]

On 09/23/2010 04:32 PM, Adam Young wrote:
> On 09/23/2010 02:51 PM, Endi Sukma Dewata wrote:
>> ----- "Adam Young"<ayoung at redhat.com>  wrote:
>>
>>> self-service
>>>       Selects the site map based on the presence or absense of 
>>> rolegroups for
>>>       the current user.  If the user has no rolegroups, UI defaults to
>>>       the Details page for that user.
>> NACK. The window_hashchange() is expecting 2 levels of tabs:
>>
>> var admin_tabs_lists = [
>>      ['identity', 'IDENTITY', [
>>          ['user', 'Users', ipa_entity_setup],
>>      ]]
>> ];
>>
>> but the self-service tab is only 1 level:
>>
>> var self_serv_tabs_lists =
>>      [['user', 'Users', ipa_entity_setup]];
>>
>> Currently window_hashchange()will ignore if there's no 2nd level
>> tabs defined:
>>
>> for (var i = 0; i<  nav_tabs_lists.length; ++i) {
>>      var t = nav_tabs_lists[i]; // 1st level tab
>>
>>      // if no 2nd level tabs ->  skip
>>      if (typeof t[2] != 'function'&&  t[2].length) {
>>          for (var j = 0; j<  t[2].length; ++j) {
>>              var tt = t[2][j]; // 2nd level tab
>
> OK, put back the identity tab
>
>> There's also a typo on line 44, the variable name should
>> have been nav_tabs_lists instead of nav_tabs_list. But the
>> code will still work anyway.
>
> Yeah, that variable was ignored, and it made an implicit Global.  Fixed.
>> -- 
>> Endi S. Dewata
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
ACKed on IRC, pushed to master
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20100923/1f08aab9/attachment.htm>