[Freeipa-devel] admiyo-freeipa-0048-Item-Level-Undo.patch

Adam Young ayoung at redhat.com
Wed Sep 29 23:27:48 UTC 2010


On 09/29/2010 06:19 PM, Endi Sukma Dewata wrote:
> ----- "Adam Young"<ayoung at redhat.com>  wrote:
>
>    
>> Item Level Undo
>>
>> Also adding some unit tests for details.
>> Using JQuery UI buttons for update and reset
>>
>> This has the added benefit of letting the user know when the screen
>> has been submitted, as the "undo" buttons go away.
>>      
>    
>> Rebased on top
>> of Endi's last patch, and added my tests to index and all tests
>>      
> It doesn't work with attributes that originally don't have any value.
> The previous_value will be undefined so the input field wouldn't be reset.
>
> details.js:
> 406 var previous_value = entry_attrs[key];
> 407 if (previous_value){
> 408 this.previousElementSibling.value = previous_value;
> 409 }
>
> --
> Endi S. Dewata
>    
Ah..good catch.  OK  I'll fix




More information about the Freeipa-devel mailing list