[Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

[Endi Sukma Dewata]

On 4/27/2011 8:09 PM, Adam Young wrote:
>> <div name='user' class='entity'>
>> <div class='entity-header'>
>> <div class='entity-title'/>
>> <div class='entity-controls'/>
>> <div class='entity-search'/>
>> <div class='entity-tabs'/>
>> </div>
>> <div class='entity-content'>
>> <div name='search' class='facet'>
>> <div class='facet-header'/>
>> <div class='facet-content'/>
>> </div>
>> <div name='details' class='facet'/>
>> </div>
>> </div>
>>
>> What do you think? We can do this in a separate patch if it's too
>> complicated.
>
> Very clean: I like it a lot. I'd like to do it as a separate patch, just
> to keep clear what we are doing.

Found some issues:

1. The selector on entity.js:314 is missing a # sign:

    var facet_container = $('#'+facet.name +'_container',
    entity.header.content);

2. Entity header is not updated after switching facets.
    Open Users tab, click one of the users, then click Back to Search.
    The title and buttons are wrong and the facet tabs do not disappear.
    This is because entity header is shared with other facets and isn't
    updated if the facet container already exists.

-- 
Endi S. Dewata