[Freeipa-devel] [PATCH] 136 Merged IPA.cmd() into IPA.command().

[Adam Young]

On 04/12/2011 12:09 PM, Endi Sukma Dewata wrote:
> The IPA.cmd() has been merged into IPA.command(). All invocations
> and test cases have been converted.
>
> Ticket #988
>
> Passed JSLint, QUnit and Selenium tests.
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

I'm not a fan of the string concatination in the command calls.  I'd 
prefer to do that inside the IPA.command object, the way it was done in 
IPA.cmd:


{
     entity:cert
     method:revoke:
...
}


and

if (spec.entity){
    method = spec.entity + spec.method;
}else{
    method = spec.method;
}


Other than that, it looks good.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110413/40e26f57/attachment.htm>