[Freeipa-devel] [PATCH] 14 Run lint during each build

[Jan Cholasta]

On 26.4.2011 18:14, Martin Kosek wrote:
> On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote:
>> Automatically run the lint script during make rpms|client-rpms|srpms.
>>
>
> NACK until ticket 1184 is resolved and pushed. Currently, pylint check
> fails when optional python packages (like python-rhsm) are not installed
> on the machine. We should be able to build IPA without those packages
> installed.

I think printing a note asking the developer to kindly install the 
missing packages would be sufficient. AFAIK there are currently only 2 
optional packages: python-rhsm and python-krbV. python-krbV is optional 
only for the client part of IPA, so you most likely have it already 
installed and installing python-rhsm is not really much of a chore. That 
way all of the code would always be checked and the lint script would be 
free of the unnecessary complexity of handling missing packages.

>
> Martin

-- 
Jan Cholasta