[Freeipa-devel] [PATCH] 41 Verify that the external CA certificate files are correct

[Jan Cholasta]

On 18.8.2011 17:47, Rob Crittenden wrote:
> Jan Cholasta wrote:
>> On 17.8.2011 10:27, Jan Cholasta wrote:
>>> Verify that --external_cert_file and --external_ca_file are both
>>> readable, valid PEM files and that their subject/issuer is correct.
>>>
>>> Also fixes ipalib.x509.load_certificate_from_file.
>>>
>>> https://fedorahosted.org/freeipa/ticket/1572
>>>
>>> Honza
>>>
>>
>> Patch attached.
>
> nack, but this is very close.
>
> If the CA is a chain the signing check may fail if the first cert isn't
> the one that signed the CSR. You need to check all CA certs in the file.
>
> rob

Fixed.

Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-41.1-external-ca-verify.patch
Type: text/x-patch
Size: 5109 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110823/f1378e8c/attachment.bin>