[Freeipa-devel] [PATCH] 052 Better displaying of long names in tables and facet headers
Petr Vobornik
pvoborni at redhat.com
Thu Dec 8 14:31:01 UTC 2011
Tables columns have computed width. If value in one column is very long
it widens the column and shortens others. This change causes that body
columns are not aligned with header columns which makes the table less
readable.
Applying 'word-break: break-all' style breaks the word into multiple
lines and solves the problem.
Similar problem is in details facet when displaying text values. Very
long values widens the table and a horizontal slider is displayed, which
is bad. Applying same solution.
In facet headers and breadcrumb navigation breaking the pkey looks bad -
there should be only on line of pkey. To solve this, the pkey is limited
to 63 characters (empirically measured). Long pkeys are cut. Uncut pkey
is set as a title to avoid losing information.
Whole breadcrumb could be about 140 chars (with current styles). 10
chars is reserved for entity link, 60 for pkey the rest (about 60 (some
reservation for '>>')) for parent pkeys. The assumption is that the
parent pkeys wouldn't be so long so they won't be cut anyway.
Column width calculation in tables was improved. Now it counts with cell
spacing, padding, border. It uses these assumptions:
cell-spacing: 2px
cell-padding: 6px th:right, left; td: left
cell-border: th:1px; td:0px
It would be better to get these measures dynamically. But right now it
is good enough - better than previous calculation.
Result: data cells are aligned with their header. This alignment fails
if vertical scrollbar is displayed (existing problem).
Also added padding to headers in association adder dialog.
https://fedorahosted.org/freeipa/ticket/1890
--
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0052-Better-displaying-of-long-names-in-tables-and-facet-.patch
Type: text/x-patch
Size: 9123 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20111208/5f8228aa/attachment.bin>
More information about the Freeipa-devel
mailing list