[Freeipa-devel] [PATCH] 058 Distinguishing of external values in association tables

[Endi Sukma Dewata]

ACK and pushed to master. Possible future enhancements:

On 12/15/2011 6:54 AM, Petr Vobornik wrote:
> * For tables with possible external values a 'external' column was
> added. It displays "True" if the value is external and nothing if not.
> Displaying nothing is intentional. If user sees some text in external
> column he immediately knows that the record is external without even
> reading the "True" text.

1. While this is consistent with Host's Enrolled column, it is different 
from HBAC/sudo rule's Enabled column. I think we should make it more 
consistent across the board.

> * Association table widget was stripped of get_records method. Loading
> records isn't its responsibility it's a responsibility of field.

2. Similarly, the code in association.js:485-487 can also be moved into 
the field. So when the widget receives the values object it's already in 
the form of records.

> * Column was extended by possible suppressing of link creation. It's
> done by optional suppress_link argument in setup method.
> * To allow setting suppress_link attribute in inherited tables a new
> overridable method was created - setup_column.

3. Instead of adding a new parameter to the IPA.column.setup() we can 
also use a custom column and override the setup() to check whether it's 
an external member and then suppress the link.

4. The association table widget still depends on associator and 
add/remove method. They should be moved into the field.

-- 
Endi S. Dewata