[Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

Rob Crittenden rcritten at redhat.com
Tue Feb 15 17:14:49 UTC 2011


Jan Cholasta wrote:
> Fixes handling of empty lines, erroneous lines and comments in /etc/hosts.
>
> https://fedorahosted.org/freeipa/ticket/971
>

nack.

Would using line.rstrip() be better than the conditional checking 
explicitly for \n?

I don't think we can use format this way, isn't it new to python 2.7? I 
think you have to use {0} and {1}. We need to support python 2.6 as well.

rob




More information about the Freeipa-devel mailing list