[Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

[Martin Kosek]

On Tue, 2011-02-15 at 13:26 -0500, Adam Young wrote:
> On 02/15/2011 08:25 AM, Martin Kosek wrote: 
> > Many WebUI identifiers were defined in a global namespace. This is
> > not a good programming practice and may result in name clashes,
> > for example with other libraries.
> > 
> > This patch moves these variables to IPA namespace or its
> > sub-namespaces, if required.
> > 
> > https://fedorahosted.org/freeipa/ticket/212
> > 
> > 
> > _______________________________________________
> > Freeipa-devel mailing list
> > Freeipa-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> 
> 
> Martin,  he is the patch I did for the cert portion.  I'll toss it,
> but you can see what I was thinking as far as hoe to shorten the
> names:
> 
> BTW, you should reverse the names of your patch so that they start
> with freeipa, and then your user id.  

Adam, thanks for all the remarks. Here is a second version of the patch
based on your work on certificate module. I tried to keep the patch
simple without too much changes.

There are 3 new subnamespaces in this patch - sudo, cert and nav. I have
removed a lot of unused code in search.js, you may want to check it
closer. This enabled me to move search_generate_checkbox_td
functionality just to a place where its needed.

Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-031-02-remove-webui-identifiers-from-global-namespace.patch
Type: text/x-patch
Size: 64985 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110216/966f3c0a/attachment.bin>