[Freeipa-devel] [PATCH] 034 Do not use LDAP_DEPRECATED in plugins and client

[Jan Zelený]

Jakub Hrozek <jhrozek at redhat.com> wrote:
> Remove the LDAP_DEPRECATED constant and do not use functions that are
> marked as deprecated in recent OpenLDAP releases. Also always define
> WITH_{MOZLDAP,OPENLDAP} since there are conditional header includes that
> depend on that constant.
> 
> A related question - since we only support Fedora 14 now and we always
> compile with --with-openldap on that platform, should we remove the
> mozldap code altogether? I don't think it would cause any harm,
> realistically, there should be no users.
> 
> https://fedorahosted.org/freeipa/ticket/576

Nack,

please unify whitespaces in indentation. Also I'm curious about adding those 
includes in ipapwd.h - does this have any (positive/or negative) impact? They 
seem a little redundant.

Note: I think another patch changing whitespaces to correspond with our coding 
policy is in order after this one is pushed.

Jan