[Freeipa-devel] [PATCH] Uninitialized pointer read in ipa-rmkeytab

Martin Kosek mkosek at redhat.com
Mon Jan 10 13:25:37 UTC 2011


On Mon, 2011-01-10 at 13:06 +0100, Jakub Hrozek wrote:
> Nack,
> 
> same comment as the previous patch, don't use if(ptr) free(ptr);
> 
> Also one very minor style issue - please use:
> 
> if(cond) {
>  foo();
> } else {
>  bar();
> }
> 
> rather than:
> 
> if (cond) {
>   foo();
> }
> else {
>   bar();
> }

Good point with the free method. Sending second patch with these issues
fixed.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mkosek-freeipa-003-02-uninitialized-pointer-read-in-ipa-rmkeytab.patch
Type: text/x-patch
Size: 1715 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110110/5a154bf4/attachment.bin>


More information about the Freeipa-devel mailing list