[Freeipa-devel] [PATCH] Use of pointer after free in ipa-join

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/10/2011 04:15 PM, Martin Kosek wrote:
> On Mon, 2011-01-10 at 13:04 +0100, Jakub Hrozek wrote:
> 
>> Nack,
>>
>> if(ptr) free(ptr);
>>
>> is redundant, freeing a NULL pointer is a no-op. Other that that, looks
>> fine.
> 
> Attaching fixed version of patch.
> 
> Martin

Sorry, there's one more thing I haven't noticed before - please check
the return value if strdup(); in the else branch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0rJ6IACgkQHsardTLnvCVSVgCggTR3r3Q70AJflJAy28qk1qfR
qdsAn3F1QEiYFdMePVmHEiWqq49jWiPp
=KPf/
-----END PGP SIGNATURE-----