[Freeipa-devel] [PATCH] bind-dyndb-ldap: new parameter "timeout"

[Adam Tkac]

On Mon, Jan 10, 2011 at 05:26:04PM +0100, Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 01/10/2011 04:36 PM, Adam Tkac wrote:
> > On Mon, Jan 10, 2011 at 04:04:17PM +0100, Jakub Hrozek wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> On 01/06/2011 06:23 PM, Adam Tkac wrote:
> >>> Hello,
> >>>
> >>> attached patch introduces new bind-dyndb-ldap parameter called
> >>> "timeout". It controls timeout of the LDAP queries and by default is
> >>> set to 10 seconds.
> >>>
> >>> The patch solves https://fedorahosted.org/bind-dyndb-ldap/ticket/3.
> >>>
> >>> Regards, Adam
> >>>
> >>
> >> The code looks OK but I'm wondering whether it would make more sense to
> >> set it globally using ldap_set_option(LDAP_OPT_NETWORK_TIMEOUT) rather
> >> that for the single ldap_search() call. That way, any other ldap_* calls
> >> and also the LDAP bind operation would be controlled from a single place.
> > 
> > Good idea. However I would rather use LDAP_OPT_TIMEOUT. Improved patch
> > is attached.
> > 
> > Regards, Adam
> > 
> 
> Ack

Pushed to master.

-- 
Adam Tkac, Red Hat, Inc.