[Freeipa-devel] [PATCH] 037,038 Remove the original DNS plugin

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/12/2011 10:40 PM, Jakub Hrozek wrote:
> On Wed, Jan 12, 2011 at 08:58:15PM +0100, Jakub Hrozek wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 01/12/2011 08:56 PM, Jakub Hrozek wrote:
>>> I didn't find a related ticket, but I think this needs to be done. At
>>> the very least it caused confusion for QA.
>>>
>>> This patch
>>> - removes the obsolete DNS plugin
>>> - renames the new plugin to dns
>>> - moves ipa dns-resolve to the new plugin
>>> - ports the installer and the host plugin to the new interface
>>>
>>> I didn't touch the UI at all. Adam, Endi, do I need to tweak it somehow
>>> (esp. because the plugin is renamed).
>>>
>>> 	Jakub
>>
>> Attached is another version of the same patch, just formatted with -M
>> - -C, so it should hopefully look better.
>>
> 
> OK, that was still not very readable so I splitted the patches into two
> to ease the review:
> 
> 1) jhrozek-freeipa-037-03-dont-use-legacy-dns.patch:
> Port installer and host plugin to the new DNS plugin
> 
> * moves ipa dns-resolve to the new plugin
> * ports the installer and the host plugin to the new interface
> 
> 2) jhrozek-freeipa-038-rename-dns2-to-dns.patch
> No functionality change, just renames the old plugin to the new one.
> 
> I used "git format-patch -M -C --patience --full-index" to format the
> patch but git still didn't detect the replace, it seems. Is there
> anything else I can do in order to get a prettier patch? I created the
> patch with "git rm ipalib/plugins/dns.py" and then "git mv
> ipalib/plugins/dns2.py ipalib/plugins/dns.py" -- without performing rm
> first, git would complain about renaming file to another which is
> tracked.
> 
> 

Per Simo's advice, I deleted the old plugin in the first patch, now the
second one is just the rename. Looks much better now.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0uzPgACgkQHsardTLnvCWJywCcD1/wdm07l/8y9CFVDi+lg1nx
NtYAoJk3Vf6MPUcWF0zStIkE1b+K5AVV
=w775
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-038-02-rename-dns2-to-dns.patch
Type: text/x-patch
Size: 39133 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110113/d1d05e62/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-037-04-dont-use-legacy-dns.patch
Type: text/x-patch
Size: 42096 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110113/d1d05e62/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-038-02-rename-dns2-to-dns.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110113/d1d05e62/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-037-04-dont-use-legacy-dns.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110113/d1d05e62/attachment-0001.sig>