[Freeipa-devel] [PATCH] admiyo-0141-spinning-wheel.

[Adam Young]

On 01/14/2011 03:12 AM, Endi Sukma Dewata wrote:
> On 1/14/2011 2:35 AM, Adam Young wrote:
>>
>
> Mostly fine except these minor things:
>
> 1. Everytime you click Update on details facet the primary key will
>    be prepended to the header. See details.js:664:
>
>       $('h1',that.container).prepend(that.pkey);
>
> 2. The hide_activity_icon() invocations in the following methods:
>     - ajax_error_handler()
>     - http_error_handler()
>     - ipa_error_handler()
>    are unnecessary because it's been invoked earlier by success_handler
>    or error_handler.
>
Updated
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0141-2-spinning-wheel.patch
Type: text/x-patch
Size: 24646 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110114/95188c35/attachment.bin>