[Freeipa-devel] [PATCH] Make ipa permission-add ask for optional attributes

Rob Crittenden rcritten at redhat.com
Mon Jan 24 14:53:08 UTC 2011


Jan Zelený wrote:
> Rob Crittenden<rcritten at redhat.com>  wrote:
>> Jan Zeleny wrote:
>>> Either one of type, filter, subtree, targetgroup, attrs or memberof is
>>> required.
>>>
>>> https://fedorahosted.org/freeipa/ticket/819
>>>
>>> Jan
>>
>> Do you think the prompt should be annotated somehow to indicate that the
>> optional attributes are optional? I've been wondering about this since I
>> added alwaysask for managing permissions, it isn't very clear that you
>> don't have to enter something.
>>
>> I'm not sure how we would do it, a *, or some other indicator?
>>
>> rob
>
> That's definitely a good idea, but if we will use *, I think it should be
> present for required arguments, otherwise it might be confusing - on the web *
> usually marks required fields. From this point of view square brackets are used
> to indicate something is optional, so about something like [Subtree]:?
>
> Jan

Yes, that sounds perfect. I filed ticket 
https://fedorahosted.org/freeipa/ticket/832

rob




More information about the Freeipa-devel mailing list