[Freeipa-devel] [PATCH] 029 Enforce uniqueness on (key, info) pairs in automount keys

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/25/2011 04:42 AM, Rob Crittenden wrote:
> Jakub Hrozek wrote:
>> On 01/21/2011 05:55 PM, Rob Crittenden wrote:
>>> Jakub Hrozek wrote:
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA1
>>>>
>>>> On 01/10/2011 05:15 PM, Jakub Hrozek wrote:
>>>>> On 12/20/2010 03:33 PM, Jakub Hrozek wrote:
>>>>>> On 12/20/2010 02:49 PM, Jakub Hrozek wrote:
>>>>>>> Attached is a patch that changes the uniqueness constraint of
>>>>>>> automount
>>>>>>> keys from (key) to (key,info) pairs. The patch is not really
>>>>>>> standard
>>>>>>> baseldap style. The reason is that during development, I found that
>>>>>>> baseldap is really dependent on having a single primary key and also
>>>>>>> during many operations accessing it as keys[-1].
>>>>>
>>>>>>> Please note that the ipa automountkey-* commands used to have three
>>>>>>> args, now its two args and two required options (that compose the
>>>>>>> tuple
>>>>>>> that is primary key). I know next to nothing about UI, but I assume
>>>>>>> this
>>>>>>> has consequences as the JSON marshalled call needs to be different
>>>>>>> now.
>>>>>>> Can someone point me to the place in code that I need to fix now?
>>>>>
>>>>>>> Fixes:
>>>>>>> https://fedorahosted.org/freeipa/ticket/293
>>>>>
>>>>>> Sorry, I left some debugging statements in. Attached is a new patch.
>>>>>
>>>>> Attached is a patch that applies cleanly on top of origin/master.
>>>
>>> Can you provide some guidance on how to test this patch?
>>>
>>> thanks
>>>
>>> rob
>>
>> Sure:
>>
>> The main change to CLI is that both key and info must be provided. These
>> are put into the description attribute, at the same time this (key,info)
>> tuple is checked for uniqueness.
>>
>> The automount test is a good start for testing the patch. It also tests
>> a duplicate direct map. To test the duplicates manually:
>>
>> ipa automountlocation-add baltimore
>> ipa automountmap-add baltimore auto.direct2
>> ipa automountkey-add baltimore auto.master --key=/- --info=auto.direct2
>> ipa automountlocation-tofiles baltimore
>>
>> You should see something like:
>> /etc/auto.master:
>> /- /etc/auto.direct
>> /- /etc/auto.direct2
>> ---------------------------
>> /etc/auto.direct:
>> ---------------------------
>> /etc/auto.direct2:
> 
> Ack with two conditions and a question:
> 
> Conditions:
> 
> 1. Check with qe to see if they already have tests for automount. If
> they do we'll need to coordinate getting their tests updated.

Jenny, I see you are in the CC list. Do you know?

> 2. The samples in the command help don't use the --key argument, can you
> update them?

Sorry, but I think the samples are OK. I just tried cut-n-pasting all of
them into the terminal and found one glitch (new patch that fixes just
that typo in help is attached), but all the ipa automountkey-* commands
list the --key parameter in help.

Or do you mean something else than the output of ipa help automount?

> 
> Question:
> 
> Can you import multiple direct maps?
> 

Yes, just tested. If someone would like to test, please note that when
you create a new automount location, a direct map is created for the new
location by default. This is how I imported a /etc/auto.master file with
multiple direct maps:

# create a new location
ipa automountlocation-add testimport
# remove the reference to the direct map from the auto.master map
ipa automountkey-del testimport auto.master --key=/- --info=auto.direct
# remove the auto.direct location
ipa automountmap-del testimport auto.direct
# import the new maps
ipa automountlocation-import testimport /etc/auto.master

My /etc/auto.master looks something like this:
- -----
/misc	/etc/auto.misc
/net	-hosts
/-	/etc/auto.direct
/-	/etc/auto.direct2
/home	/etc/auto.home
- -----
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0+zdYACgkQHsardTLnvCVL/ACghLxen44ZZv+qIFBm6Cz3cinM
oMEAoLAAUtCKnxDlUHKtpyMvg75Zq/Iq
=7MbL
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-029-05-automount-keys-uniqueness.patch
Type: text/x-patch
Size: 27533 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110125/20e3158f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-029-05-automount-keys-uniqueness.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110125/20e3158f/attachment.sig>