[Freeipa-devel] [PATCH] 0261-entity-link-for-password-policy

[Endi Sukma Dewata]

On 6/30/2011 4:42 PM, Adam Young wrote:
>

Some issues:

1. Suppose initially you open an entry that contains a value that 
matches no_link_value, it will hide the link and show the label. Then 
suppose you open another entry that has no value, it will empty the link 
but leaving the label from the previous entry visible.

This is not a problem for password policy because cn will always have a 
value, but it might be better to change the else-clause in reset() to 
hide both the link and the label:

   that.link.css('display','none');
   that.label.css('display','none');

2. Optional: The no_link_value seems to be limited to a single value 
only. While it works fine for password policy, I suppose in other cases 
we might want to match multiple values or use some other logic. One 
solution is to put the logic that checks the value inside a method that 
can be overriden by the subclass.

-- 
Endi S. Dewata