[Freeipa-devel] [PATCH] 37 Correct sudo runasuser and runasgroup attributes in schema

Martin Kosek mkosek at redhat.com
Tue Jul 19 09:20:51 UTC 2011


On Mon, 2011-07-18 at 23:43 +0000, JR Aquino wrote:
> https://fedorahosted.org/freeipa/ticket/1309
> 
> Added .update file to correct the sudo schema during freeipa updates on older systems.
> Modified Makefile.am to account for new .update file.
> 

NACK.

This fixes the schema well, but sudoRunAsGroup attribute is still filled
incorrectly. I think that the sudo LDAP compat plugin has to be fixed
too. These 2 rules look suspicious:

schema-compat-entry-attribute: sudoRunAsGroup=%{ipaSudoRunAsExtGroup}
schema-compat-entry-attribute: sudoRunAsGroup=%deref("ipaSudoRunAs","cn")

And one more minor issue I saw, please fix indentation in Makefile.am.

Martin




More information about the Freeipa-devel mailing list