[Freeipa-devel] [PATCH] 820 make client errors clearer

[Martin Kosek]

On Wed, 2011-07-06 at 11:03 -0400, Rob Crittenden wrote:
> Some client errors were rather generic or outright misleading. This 
> cleans up some return values and displays output from the ipa-enrollment 
> extended operation.
> 
> ticket https://fedorahosted.org/freeipa/ticket/1417

NACK.

Good patch, but I found one issue:

ipa-client/ipa-install/ipa-client-install:
-    if ret == -1 or not ds.getDomainName():
+    if ret == ipadiscovery.NO_LDAP_SERVER or not ds.getDomainName():

You check for another error. That way the domain problem will not get
caught there.

Martin