[Freeipa-devel] [PATCH] 835 set default min int, handle longs

Rob Crittenden rcritten at redhat.com
Wed Jul 20 15:32:57 UTC 2011


Martin Kosek wrote:
> On Tue, 2011-07-19 at 22:15 -0400, Rob Crittenden wrote:
>> Our handling of long values wasn't the best when dealing with negative
>> values. Added a default minint similar to maxint and validate_scalar in
>> Int to allow either int or long types. This lets it get to the min/max
>> rules where we can compare properly and give a better error response.
>>
>> Note that I changed the language slightly from value 'must be at least
>> x' to 'can be at least x'. It reads better to me this way but I'm flexible.
>>
>> https://fedorahosted.org/freeipa/ticket/1494
>>
>> rob
>
> ACK, works fine, tests are OK.
>
> I won't argue with the wording of _rule_minvalue, both reads OK to me.
>
> Martin
>

pushed to master and ipa-2-0




More information about the Freeipa-devel mailing list