[Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support

Simo Sorce simo at redhat.com
Wed Jul 20 17:54:07 UTC 2011


On Wed, 2011-07-20 at 20:36 +0300, Alexander Bokovoy wrote:
> On 20.07.2011 20:30, Alexander Bokovoy wrote:
> > I moved existing code to ipapython/platform/redhat.py.
> > ipapython/services.py is auto-generated and basically is one-liner:
> > =====
> > from ipapython.platform.<platform> import *
> > =====
> > 
> > Actual <platform> value is substituted using top-level Makefile's
> > SUPPORTED_PLAFTORM= variable (defaults to 'redhat', can be redefined
> > without modifying Makefile, in package building scripts, for example)
> > and then ipapython/services.py is generated from ipapython/services.py.in
> The original patch misses ipapython/services.py.in. I'll update patch
> but the file is really one-liner (attached).

The direction looks good to me, please keep on.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list