[Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

[Adam Young]

On 07/25/2011 08:18 PM, Endi Sukma Dewata wrote:
>
> 41. The radio buttons in the 'As Whom' section in sudo rule section 
> are missing the labels. It should show the doc attributes of the 
> ipasudorunasusercategory and ipasudorunasgroupcategory.

Fixed
>
> 42. The code in widget.js:1124-1128 can be replaced with this:
>
>    that.entity_name = spec.entity ? spec.entity.name : spec.entity_name;
>
> In general attribute declarations should be 1 liner. If it takes more 
> than 1 line it should be done in the constructor.

Fixed

>
> 43. The initialization code (set_param_info) in IPA.widget 
> (widget.js:80) was originally in init(). It should be moved into the 
> constructor.
Well, it was already, but moved to the bottom of the function and 
commented, for clarity

>
> 44. The initialization code in IPA.column (widget.js:1135-1147) was 
> originally in init(). It should be moved into the constructor.

Same as 43
>
> 45. -47.
Will defer

> 48. The initialization code (button creation) in IPA.add_dialog 
> (add.js:48-93) was moved from init() to create(). It should be moved 
> into the constructor.
Done
>
> 49. The initialization code (column creation) in 
> IPA.association_adder_dialog (association.js:157-165) was moved from 
> init() to create(). It should be moved into the constructor.
>
> 50. The attribute declaration (NORMAL_HEIGHT and WITH_EXTERNAL_HEIGHT) 
> in IPA.adder_dialog (dialog.js:341-342) should be moved to the 
> beginning of the class.

Done


For 51-55, all code that was moved to create is moved to the widget 
definition.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0270-13-removing-setters-setup-and-init.patch
Type: text/x-patch
Size: 193115 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110726/15a98780/attachment.bin>