[Freeipa-devel] [PATCH] 842 deprecation some sudorule options

Martin Kosek mkosek at redhat.com
Fri Jul 29 13:42:33 UTC 2011


On Fri, 2011-07-29 at 08:51 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Thu, 2011-07-28 at 18:53 -0400, Rob Crittenden wrote:
> >>
> >> I created a validator for each of these three to disallow management.
> >> This would be a major API change to remove them.
> >>
> >> They are useful in the find command so I hedged my bet and didn't
> >> mark
> >> the docs as deprecated, just as for -find only.
> >>
> >> rob
> >>
> >>
> >
> > NACK.
> >
> > The approach looks OK, I just think that the error message is not really
> > what we want:
> >
> > # ipa sudorule-mod srule1 --externaluser=foo
> > ipa: ERROR: invalid 'externaluser': The deny type has been deprecated.
> >
> > Martin
> >
> 
> Yikes, I had meant to go back and fix that up. Updated patch attached.
> 
> rob

Yeah, that's better :-)

ACK. Pushed to master, ipa-2-0.

Martin




More information about the Freeipa-devel mailing list