[Freeipa-devel] [PATCH] 0229-automount-delete-key

[Adam Young]

On 06/01/2011 07:05 PM, Endi Sukma Dewata wrote:
> On 6/1/2011 10:09 AM, Adam Young wrote:
>>> 11. The option values for automount map adder dialog could be
>>> simplified to "direct" and "indirect".
>
>> The values used are what is appended to the command's method. Had to
>> leave them as is to keep that working.
>
> The option values (direct & indirect) could be translated internally
> into method names (add and add_indirect). It wouldn't matter for users,
> but it could improve clarity of Selenium tests. This is no big deal,
> it can be fixed another time.
>
> One more issue:
>
> 12. The map type radio buttons in the automount map adder dialog retain
>     the previous selection. Try creating an indirect map, then click Add
>     again, the indirect radio is selected but the mount point and parent
>     map fields are not shown.
>
> It's ACKed. Issue #12 could be fixed before push.
>
#12 was fixed and pushed.  I also added sample data for 
automountmap_add_indirect.