[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] 29 Raise DuplicateEntry Error when adding a duplicate sudo option



On Jun 16, 2011, at 8:01 AM, Rob Crittenden wrote:

> JR Aquino wrote:
>> On Jun 15, 2011, at 8:03 AM, Rob Crittenden wrote:
>> 
>>> A minor issue and a question.
>>> 
>>> The minor issue is you changed a couple of options from optional to mandatory, which is fine, but we need to bump up the minor version in VERSION (older clients otherwise could not send the string and blow things up).
>> 
>> Is there a rule of thumb or document that details when this is appropriate?
>> 
>> 
>>> The question is, should we raise EmptyModList() when removing an option that doesn't exist or NotFound(reason=_())? I think the second might be more explanatory but might be harder for handle in scripts (how would you distinguish between entry not found and option not found)?
>>> 
>>> rob
>> 
>> 
>> As per IRC conversation:
>> Added new Exception: AttrValueNotFound
>> Incremented minor version in VERSION
>> Adjusted API
>> 1276 (Raise AttrValueNotFound when trying to remove a non-existent option from Sudo rule)
>> 1277 (Raise DuplicateEntry Error when adding a duplicate sudo option)
>> 1308 (Make sudooption a required option for sudorule_remove_option)
>> 
> 
> This is very close, found a couple more issues:
> 
> I don't think I was very clear in what to update in VERSION, you want it to look like this:
> 
> diff --git a/VERSION b/VERSION
> index 6cbf732..e31f0d0 100644
> --- a/VERSION
> +++ b/VERSION
> @@ -79,4 +79,4 @@ IPA_DATA_VERSION=20100614120000
> #                                                      #
> ########################################################
> IPA_API_VERSION_MAJOR=2
> -IPA_API_VERSION_MINOR=5
> +IPA_API_VERSION_MINOR=6
> 
> Two tests are failing. One is failing because externalhost is returned as a tuple (rather than not at all). The second because sudorule_remove_option has changed the type of data being returned.
> 
> rob

Ok, the VERSION issue is resolved, and the ipasudoopt test issue is solved.

I have created: https://fedorahosted.org/freeipa/ticket/1339 to address the externalhost tuple as it is separate from the sudo options effort.

Attachment: bin5BtLIEmWrQ.bin
Description: freeipa-jraquino-0029-Raise-DuplicateEntry-Error-when-adding-a-duplicate.patch


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]