[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Freeipa-devel] [PATCH] 0009-Tab-and-spacing-on-list



On 6/21/2011 11:09 AM, Kyle Baker wrote:
Changes some spacing on the list and facet tab pages as well as styles the tabs. This patch and 0010 should result in the attached screen shot.

Some issues:

1. This is actually an existing problem, but it looks like we're relying a lot on button labels which will be translated so the styling will not work in other languages.

[title="Enroll"] {
       font-size: 1.3em !important;
       padding: 0 0 2px 6px;
}

I think we should use the 'facet-controls' CSS class instead.

2. The patch defines the styling for individual facets such as:

[name="member_role"] {
       margin-top: 30px;
       margin-left: 7px;
}

This will be a maintenance issue. I think we should use the 'facet' CSS class instead.

--
Endi S. Dewata


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]