[Freeipa-devel] [PATCH] 0249-optional-uid.

[Adam Young]

On 06/21/2011 11:39 AM, Adam Young wrote:
> On 06/21/2011 11:06 AM, Endi Sukma Dewata wrote:
>> On 6/20/2011 8:25 PM, Adam Young wrote:
>>> Note that this patch needs a review by UXD in addition to code review
>>
>> Some issues:
>>
>> 1. The patch tries to find the elements to be hidden using
>>    span.find('input'). This will not work with all widgets because
>>    some widgets use other elements or some combination. I think it's
>>    better to add the link outside the span, then hide the span itself
>>    to hide the entire widget.
>
> That makes sense.  We'd have an input span and an optional_link  span.
>
>>
>> 2. Hiding the optional widgets but not the labels might not be enough
>>    to simplify the screen because they still occupy some space. Another
>>    solution is to hide both the labels and the widgets (i.e. the entire
>>    row) then have a link for to hide/show all optional fields somewhere
>>    else.
>>
> No, since optional fields are not necessarily related.
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0249-1-optional-uid.patch
Type: text/x-patch
Size: 4222 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110624/ea028a73/attachment.bin>