[Freeipa-devel] [PATCH] 760 don't crash when calculating indirect

Martin Kosek mkosek at redhat.com
Thu Mar 31 11:22:21 UTC 2011


On Wed, 2011-03-30 at 10:46 -0400, Rob Crittenden wrote:
> Rob Crittenden wrote:
> > This prevents an internal error when calculating direct vs indirect
> > membership.
> >
> > ticket 1133
> >
> 
> I accidentally included a change from another patch. Updated patch attached.
> 
> rob

I think it is OK. But I would suggest adding some comment to the code -
a reason why we pass the ValueError exception. It may not be
self-explanatory when we return to this code in the future.

Martin




More information about the Freeipa-devel mailing list