[Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

[Adam Young]

On 05/02/2011 09:28 PM, Endi Sukma Dewata wrote:
> On 4/27/2011 9:39 PM, Endi Sukma Dewata wrote:
>> On 4/27/2011 8:47 PM, Adam Young wrote:
>>> The more I think about it, the more I think that this structure can be
>>> created by the navigation code, and then passed to the entity to
>>> populate. The entity-header function moves to navigation.js, but does
>>> not have a reference to the entity yet. When an entity tab gets
>>> activated, we then populate this structure. everything can get created
>>> on demand.
>>
>> Not sure, I'd have to see how it's implemented. My concern is whether it
>> would limit entity customization.
>
> This is my attempt at restructuring the DOM and the code:
> http://edewata.fedorapeople.org/freeipa/install/ui/index.html
>
> It's still work in progress, but the main changes are:
> 1. Navigation is modified to use entity names instead of numerical
>    index.
Good, ver y good.  This will simplify relationships.

> 2. Entity content is moved out of the navigation structure into a
>    separate container.
Interesting call.  I'm pretty sure I am in favor of it, but I'd like to 
hear your rartionale.

> 3. Each facet now has separate container, so we don't need to
>    redraw the page every time we open it.
> 4. Buttons are moved into facet header. They will appear under the
>    facet tab groups.
>
> The code is available in the navigation branch in this repository:
> git://fedorapeople.org/~edewata/repo.git

I'll wait until you give me the go ahead to review, but the DOM 
structure looks good.