[Freeipa-devel] [PATCH] 064 Improve service manipulation in client install

[Martin Kosek]

On Thu, 2011-05-12 at 11:40 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Tue, 2011-05-10 at 10:06 -0400, Rob Crittenden wrote:
> >> Martin Kosek wrote:
> >>> Remove redundant ipa-client-install error message when optional nscd
> >>> daemon was not installed. Additionally, use standard IPA functions
> >>> for service manipulation and improve logging.
> >>>
> >>> https://fedorahosted.org/freeipa/ticket/1207
> >> Nack, a client-only install isn't going to have ipaserver to import from.
> >
> > Good catch, I didn't realize that. Will do next time.
> >
> > I have moved the /sbin/service and /sbin/chkconfig control routines to
> > ipautil library, which are called by ipa-client-install.
> >
> > I have left the interface in ipaserver.install.service as it used
> > through many scripts and we could use this interface later when
> > implementing a native systemd support. The deciding logic what init
> > system to use use can be then hidden behind this interface.
> >
> >>
> >> Ignoring certmonger not starting was for the case where it is already
> >> running. Ideally we should check the status of the service and start it
> >> if necessary.
> >
> > I think I have not touched this logic, I just added few logging
> > statements that we can analyze when future user's will fill us bug
> > reports :-)
> >
> >>
> >> Some of this could be moved to ipapython as that is where common,
> >> non-framework code goes.
> >
> > Yeah, I chose ipapython.ipautil library. Please, take a look at the
> > attached patch.
> >
> > Martin
> 
> Ack

Pushed to master, ipa-2-0.

Martin