[Freeipa-devel] [bind-dyndb-ldap] Code cleanup

Adam Tkac atkac at redhat.com
Tue May 17 12:52:38 UTC 2011


Hello,

attached series of patches cleans code a little (mostly removes unused
variables) and makes locking inside bind-dyndb-ldap more readable and
understandable.

Most of the cleanup series gets rid of the ldap_connection->database
reference because there is a reference from "database" variable to
ldap_connection. This "double link" makes current locking
hard-to-understand.

I tested this series well, it shouldn't cause any regression.

Regards, Adam
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Remove-unused-lock-from-ldapdb_t.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Use-LOCK-instead-of-CONTROLED_LOCK-in-destroy_ldap_c.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-Remove-ldap_connection-database-mctx-refs-use-direct.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0002.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-Don-t-use-ldap_connection-database-fake_mnape-refere.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0003.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0005-Don-t-reference-ldap_connection-database-conn_semaph.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0004.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0006-ldap_connection_t-has-now-it-s-own-reference-to-memo.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0005.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0007-Remove-the-rest-of-ldap_connection-database-referenc.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0006.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0008-Store-connections-to-LDAP-in-array-instead-of-in-lis.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0007.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0009-Remove-unused-ldap_connection.base-variable.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0008.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0010-Add-note-about-locking-in-ldap_helper.c.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110517/39e68b97/attachment-0009.ksh>


More information about the Freeipa-devel mailing list