[Freeipa-devel] [PATCH] 0228-create-entities-on-demand
Endi Sukma Dewata
edewata at redhat.com
Mon May 23 16:06:15 UTC 2011
On 5/23/2011 9:42 AM, Adam Young wrote:
> Patch 227 is the automount patch that I still am not ready to submit.
> This patch stands alone.
A few issues in IPA.get_entity():
1. It executes that.entities.get() twice. The result of the first
invocation can be stored in a variable and reused later. The result
of the factory() invocation can be assigned to the same variable.
2. It executes factory = that.entity_factories[name] twice. The second
one can be removed.
Other than that it's ACKed and can be pushed after fixing the above issues.
--
Endi S. Dewata
More information about the Freeipa-devel
mailing list